Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Persian translation for before and after #2941

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

azim-kordpour
Copy link
Contributor

@azim-kordpour azim-kordpour commented Feb 9, 2024

Hi,
Persian is my mother tongue and these little changes make a meaningful translation in which developers use methods like diffForhumans.
An example in English would be like this:
2 years back
2 years forward

Although they might be right, they are not common and meaningful.

@kylekatarnls kylekatarnls added the translation Rely to internationalization label Feb 9, 2024
@kylekatarnls kylekatarnls added this to the 3.1.0 milestone Feb 9, 2024
Copy link
Collaborator

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 🙏

@kylekatarnls kylekatarnls changed the title Make a meaningful translation in fa.php (Persian) Fix Persian translation for before and after Feb 9, 2024
@kylekatarnls kylekatarnls merged commit 1bf13e0 into briannesbitt:master Feb 9, 2024
20 checks passed
@mokhosh
Copy link

mokhosh commented Mar 12, 2024

@azim-kordpour you seem to have misunderstood the semantics of what you have changed. These are relative to another time, not "now", so the previous translation was correct, and you have made it incorrect.

@mokhosh
Copy link

mokhosh commented Mar 12, 2024

@kylekatarnls please revert this.

@kylekatarnls
Copy link
Collaborator

kylekatarnls commented Mar 12, 2024

Hello @mokhosh and @azim-kordpour, just to double check the semantic can you please translate parts in brackets here:

  • from_now I have an appointment [in 2 hours] (from now)
  • ago I had an appointment [2 hours ago] (in the past)
  • after I have a first appointment at 12 and another one [2 hours after] (relative to the first one, can be in the past or future)
  • before I have an appointment at 12 and another one [2 hours before] (relative to the first one, can be in the past or future)

@mokhosh
Copy link

mokhosh commented Mar 12, 2024

  • from_now would be دیگر in pure Farsi, and بعد if you don't mind a little Arabic in your Farsi.
  • ago would be پیش in pure Farsi, and قبل if you don't mind a little Arabic.
  • after depend on whether you mention the time that you're comparing it to or not. If you don't, it's just بعد. If you do, you need to add از and it becomes بعد از. So, [2 hours after] would be بعد, but [2 hours after the first appointment] would be بعد از.
  • before has the same dynamics as after, but it's ‍قبل and قبل از.

So, it depends whether you use this Carbon feature, to mention both times that you're comparing, or you just mention one.

And this would be a breaking change for those who rely on the previous semantics.
For example if they have something like this but in Farsi:

This article has been edited {{ $updated_at->diffForHumans($created_at) }} it was created.

@azim-kordpour
Copy link
Contributor Author

@mokhosh You are right, it would be a breaking change in some cases.
Thank you for the explanation.

@kylekatarnls these commits should be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants