Attempt to use empty <option> element as 'placeholder' followed by 'placeholder' attribute. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>' convention are now used as the 'placeholder' text in the widget then fallowed the current behaviour to use the 'placeholder' attribute. This plays nicer with forms generated as per the convention 'placeholder label option': http://dev.w3.org/html5/spec-preview/the-select-element.html. Also modified '.gitignore' to skip WebDAV cache/control files.
|
Nice! |
brianreavis
added a commit
that referenced
this pull request
Aug 13, 2013
o0x2a
added a commit
to o0x2a/jquery-placeholder
that referenced
this pull request
Nov 13, 2013
When using [selectize](https://github.com/brianreavis/selectize.js) alongside jquery.placeholder, it adds the string 'undefined' when clicking on a selected value to change it. This is caused because the placeholder is set with an [empty option inside select](http://dev.w3.org/html5/spec-preview/the-select-element.html), then [selectize](selectize/selectize.js#69) turn this to an `input` element and set the proper `placeholder` attribute. It means an unnecessary placeholder event has been fired on an element which expected to have placeholder. This change fix this issue by checking if the value of`placeholder` attribute is valid before adding it to the `input` element. This good be an idea to implement placeholder support for `select` elements as it is conformed with [w3c](http://dev.w3.org/html5/spec-preview/the-select-element.html).
| @@ -2575,7 +2575,8 @@ | |||
| var $input = $(this); | |||
| var tag_name = $input[0].tagName.toLowerCase(); | |||
| var settings_element = { | |||
| 'placeholder' : $input.attr('placeholder'), | |||
| 'placeholder' : $input.children('option[value=""]').text() || $input.attr('placeholder'), | |||
There was a problem hiding this comment.
Is there any reason that the empty valued option should take precedence over the placeholder attribute? It seems like right now if you want to have an option with the empty string as a value, it is impossible. If the placeholder took precedence, then you could have an empty valued option by setting the placeholder to something else. Could this line be changed to
'placeholder' : $input.attr('placeholder') || $input.children('option[value=""]').text(),
without too much trouble?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select's placeholders based on empty '<option value=””>placeholder</a>' convention are now used , but if possible the current default behaviour to use the 'placeholder' attribute is used. This plays nicer with forms generated as per the convention 'placeholder label option': http://dev.w3.org/html5/spec-preview/the-select-element.html. Also modified '.gitignore' to skip WebDAV cache/control files.