build.rs: Refactor preassembly in package process in preparation for aarch64-pc-windows-msvc.

[briansmith]

No description provided.

[briansmith]

@awakecoding @Alovchin91 Please review this. This generalizes the logic in the package process so that it can use the C compiler to assemble code instead of assuming that nasm should be used. for aarch64-pc-windows-msvc, you'd still need to add the AsmTarget entry and do some minimal changes, but I think this will allow you to get rid of clang() in your PR.

[awakecoding]

LGTM

[codecov]

Codecov Report

Merging #1346 (329072e) into main (c8ca693) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1346   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         117      117           
  Lines       17826    17826           
  Branches      195      195           
=======================================
  Hits        16547    16547           
+ Misses       1245     1244    -1     
- Partials       34       35    +1     

Impacted Files	Coverage Δ
crypto/poly1305/poly1305.c	98.43% <0.00%> (-0.53%)	⬇️
src/aead/less_safe_key.rs	96.55% <0.00%> (+0.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ca693...329072e. Read the comment docs.

[briansmith]

Good questions. I just submitted PR #1347 to replace Target::is_git and to document why we do this weird stuff. I've verified that it is easy to rebase this PR on top of that one, so once that's merged, I'll update this PR with the clarified version.

[briansmith]

Good questions. I just submitted PR #1347 to replace Target::is_git and to document why we do this weird stuff. I've verified that it is easy to rebase this PR on top of that one, so once that's merged, I'll update this PR with the clarified version.

I merged PR #1347 and rebased this PR on top of it.

[briansmith]

Thanks for the review. I think the construction of Target is now much clearer thanks to the changes prompted by your questions.

[briansmith]

I've now rebased this on top of #1348.

[briansmith]

Not sure what's going on with the aarch64-apple-darwin nightly build in CI that is failing. Possibly a regression in the Rust Nightly toolchain?

[briansmith]

Not sure what's going on with the aarch64-apple-darwin nightly build in CI that is failing. Possibly a regression in the Rust Nightly toolchain?

I rebased this on top of PR #1349 to allow CI to work.