Retrieve crypto
from global instead of Window in WASM
#1508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At 1Password we use ring in our WebExtension, and extensions are currently moving to Manifest V3, where extension code will be run within a service worker. To continue using ring, I developed this patch which allows the WASM code to access
crypto
from the global without panicking ifwindow
is missing (like in a worker).How to test
make
update-test
branchmake
againNotes
There are a couple of related things that may be worth looking in to in place of this PR as is:
get_crypto
could be cached in a thread_local if that's a performance win. I haven't done any benchmarking there yet but am happy to do so.