Add support and CI workflow for riscv64 #1627

leso-kn · 2023-08-19T16:21:15Z

As there's been few recent activity on related PRs, this is #1574 rebased on latest main with:

git commit-attribution to involved developers and
sanetized commit messages to match the naming used by ring

Tested and working on Alpine Linux (riscv64 with musl libc).

briansmith

Thank you for this. I appreciate the thoroughness of this PR. A few questions.

build.rs

include/ring-core/base.h

mk/cargo.sh

src/aead/aes.rs

briansmith · 2023-09-19T15:48:52Z

There is a merge conflict in ci.yml that needs to be resolved before I can submit this to Github Actions. Please rebase this onto main.

leso-kn · 2023-09-19T16:10:28Z

Thanks for the thorough review :) Applied the pointed out suggestions and rebased onto main!

mk/install-build-tools.sh

briansmith · 2023-09-19T16:25:43Z

Have you really tested this on riscv32? I'm wondering if we should just drop that part.

leso-kn · 2023-09-19T16:31:13Z

I personally only tested riscv64. The commit contains both as it's based on the work of @amock and @xfbs, while the second commit is based on @light4's implementation, which was targeted for riscv64 only.

I believe we will have tests through the CI workflow for riscv64, do you prefer that we add an entry in the CI config for riscv32 as well or rather to remove that part from the first commit?

briansmith · 2023-09-19T16:33:03Z

I believe we will have tests through the CI workflow for riscv64, do you prefer that we add an entry in the CI config for riscv32 as well or rather to remove that part from the first commit?

I'd rather we just remove it for now. We can add it back if/when we have somebody who is really needing it and who can help test it.

leso-kn · 2023-09-19T16:40:43Z

Alright then. I'll keep riscv32 support on this branch and limited this branch to riscv64 now (3bc2da6).

Regarding the previous comment, I've also added the missing use_clang in install-build-tools.sh.

codecov · 2023-09-19T17:13:43Z

Codecov Report

Merging #1627 (16837d1) into main (bb64b55) will increase coverage by 3.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   92.12%   96.01%   +3.88%     
==========================================
  Files         132      133       +1     
  Lines       18917    19885     +968     
  Branches      199      199              
==========================================
+ Hits        17428    19092    +1664     
+ Misses       1451      754     -697     
- Partials       38       39       +1

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

briansmith · 2023-09-26T17:45:18Z

include/ring-core/base.h

@@ -89,6 +89,9 @@
 #elif defined(__MIPSEL__) && defined(__LP64__)
 #define OPENSSL_64_BIT
 #define OPENSSL_MIPS64
+#elif defined(__riscv) && __riscv_xlen == 64


BoringSSL uses __SIZEOF_POINTER__. I don't think that using the pointer size is as relevant for ring as it is for BoringSSL so I am open to using __riscv_xlen instead. Any thoughts on this?

#elif defined(__riscv) && __SIZEOF_POINTER__ == 8 #define OPENSSL_64_BIT #define OPENSSL_RISCV64

briansmith · 2023-09-26T18:20:44Z

@leso-kn You probably didn't notice but the CI failed. It seems like the linking configuration isn't correct.

I would stil llike to use the clang-based build system, but if you can't get it working, I'm OK with reverting back to what you had before with the GCC-based build system.

briansmith · 2023-09-27T01:10:22Z

@leso-kn You probably didn't notice but the CI failed. It seems like the linking configuration isn't correct.

I would stil llike to use the clang-based build system, but if you can't get it working, I'm OK with reverting back to what you had before with the GCC-based build system.

It seems like you just need to change the linking so that it continues to be done by the GCC. See #1297 and #1057 where we had to do the same thing.

briansmith · 2023-09-29T20:20:43Z

PR #1663 is moving the stuff in base.h to target.h. I will merge PR #1663 ASAP so you can rebase this on top of main for the release. I am hoping to finish the BoringSSL merge today so there shouldn't be any new conflicts.

briansmith · 2023-09-30T06:01:39Z

I posted PR #1669 which rebases your changes on top of the current main branch.

briansmith · 2023-09-30T06:01:51Z

Thank you for your help with this!

leso-kn · 2023-09-30T09:15:39Z

Hey :) Sorry for the late reply, it was a quite busy week, TL is on vacation and the customer requested a lot of things at work.

Thanks for rebasing it! I'll do it here as well just for completedness, but feel free to merge either request – probably yours as the pipeline is already in progress I see.

leso-kn · 2023-09-30T09:49:55Z

@briansmith Rebasing done, with commit signing and original committer dates in case you prefer that. But feel free to merge either of the PRs :)

leso-kn · 2023-09-30T09:51:11Z

To see the difference between the PRs see here and here.

Content wise they're the same (git diff leso-kn/riscv64-support b/risc-v is equal).

briansmith · 2023-09-30T14:20:04Z

@briansmith Rebasing done, with commit signing and original committer dates in case you prefer that. But feel free to merge either of the PRs :)

OK, If you prefer this way, I will let CI run your PR and then merge yours!

Co-authored-by: Alan Mock <alan@alanmock.com> Co-authored-by: Patrick Elsen <pelsen@xfbs.net> Signed-off-by: leso-kn <info@lesosoftware.com>

Co-authored-by: light4 <root@i01.io> Signed-off-by: leso-kn <info@lesosoftware.com>

briansmith · 2023-09-30T18:45:48Z

.github/workflows/ci.yml

@@ -507,6 +512,9 @@ jobs:
          - target: i686-unknown-linux-gnu
            host_os: ubuntu-22.04

+          - target: riscv64gc-unknown-linux-gnu
+            host_os: ubuntu-22.04


The previous CI run passed except coverage. coverage failed because this was missing. I added it and now coverage is passing.

briansmith · 2023-09-30T18:46:00Z

Thank you for all your assistance with this!

Selenium-webdriver fails to compile on RISC-V due to outdated version of ring used (https://bugs.gentoo.org/912999). Ring has added RISC-V support in briansmith/ring#1627, so update ring and additional necessary crates to allow us to build on RISC-V. This change was compile tested inside a virtual machine.

Selenium-webdriver fails to compile on RISC-V due to outdated version of ring used (https://bugs.gentoo.org/918098). Ring has added RISC-V support in briansmith/ring#1627, so update ring and additional necessary crates to allow us to build on RISC-V. This change was compile tested inside a virtual machine.

briansmith reviewed Sep 19, 2023

View reviewed changes

build.rs Outdated Show resolved Hide resolved

include/ring-core/base.h Outdated Show resolved Hide resolved

include/ring-core/base.h Outdated Show resolved Hide resolved

mk/cargo.sh Outdated Show resolved Hide resolved

src/aead/aes.rs Outdated Show resolved Hide resolved

leso-kn force-pushed the riscv64-support branch from 05e5107 to 04282ec Compare September 19, 2023 16:05

briansmith reviewed Sep 19, 2023

View reviewed changes

mk/install-build-tools.sh Show resolved Hide resolved

leso-kn force-pushed the riscv64-support branch 2 times, most recently from f2ad112 to 10af6ca Compare September 19, 2023 16:39

SebastianSchildt mentioned this pull request Sep 22, 2023

RISC V support eclipse/kuksa.val#666

Closed

briansmith reviewed Sep 26, 2023

View reviewed changes

This was referenced Sep 30, 2023

update RISC-V build #1574

Closed

Hacks taken from @amock to make RISC-V build. #1436

Closed

leso-kn force-pushed the riscv64-support branch 4 times, most recently from 2da9d6d to 7d734f7 Compare September 30, 2023 09:47

ravenclaw900 mentioned this pull request Sep 30, 2023

ci(push-build): add RISC-V builds ravenclaw900/DietPi-Dashboard#504

Merged

briansmith force-pushed the riscv64-support branch from c520ad9 to ac39c13 Compare September 30, 2023 14:31

briansmith mentioned this pull request Sep 30, 2023

Add RISC-V support to CI #1669

Closed

leso-kn and others added 5 commits September 30, 2023 09:53

Add support for riscv64

4d7935a

Co-authored-by: Alan Mock <alan@alanmock.com> Co-authored-by: Patrick Elsen <pelsen@xfbs.net> Signed-off-by: leso-kn <info@lesosoftware.com>

CI: Enable riscv64 build

3ef1999

Co-authored-by: light4 <root@i01.io> Signed-off-by: leso-kn <info@lesosoftware.com>

CI: Use riscv64-linux-gnu-gcc as RISC-V linker.

32894b7

CI: Add riscv64gc-unknown-linux-gnu to the coverage target.

e7b2477

Cherry-pick BoringSSL RISC-V target support (64-bit only).

16837d1

briansmith force-pushed the riscv64-support branch from ac39c13 to 16837d1 Compare September 30, 2023 16:54

briansmith reviewed Sep 30, 2023

View reviewed changes

briansmith merged commit 165e8a7 into briansmith:main Sep 30, 2023
266 checks passed

This was referenced Sep 30, 2023

CI: Add riscv64gc-unknown-linux-gnu support to mk/. #1562

Closed

ring on riscv64 platform #1612

Closed

Add support for RISC-V #1182

Closed

rvolosatovs mentioned this pull request Oct 11, 2023

[FEATURE] add RISCV64 build wasmCloud/wasmCloud#724

Closed

jsmolic mentioned this pull request Nov 23, 2023

[rust] Update ring and required crates for riscv support SeleniumHQ/selenium#13194

Closed

8 tasks

briansmith mentioned this pull request Jan 3, 2024

Bug:"Unknown target CPU" & "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT" #1878

Closed

phanen mentioned this pull request Jan 4, 2024

Bump ring for RISCV support rrrodzilla/rusty_paseto#30

Closed

blue-freedom-technologies mentioned this pull request Jan 4, 2024

Add riscv32 support #1880

Closed

hiyasame mentioned this pull request Mar 25, 2024

修复python-mitmproxy-wireguard openeuler-riscv/oerv-team#269

Open

ub-tech mentioned this pull request Apr 30, 2024

support for RISCV32 #2041

Closed

kasperk81 mentioned this pull request May 13, 2024

cargo install sccache fails on Starfive VisionFive 2 Risc-V SBC mozilla/sccache#1636

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support and CI workflow for riscv64 #1627

Add support and CI workflow for riscv64 #1627

leso-kn commented Aug 19, 2023

briansmith left a comment

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading

briansmith Sep 26, 2023

briansmith commented Sep 26, 2023

briansmith commented Sep 27, 2023

briansmith commented Sep 29, 2023

briansmith commented Sep 30, 2023

briansmith commented Sep 30, 2023

leso-kn commented Sep 30, 2023

leso-kn commented Sep 30, 2023

leso-kn commented Sep 30, 2023 •

edited

Loading

briansmith commented Sep 30, 2023

briansmith Sep 30, 2023

briansmith commented Sep 30, 2023

Add support and CI workflow for riscv64 #1627

Add support and CI workflow for riscv64 #1627

Conversation

leso-kn commented Aug 19, 2023

briansmith left a comment

Choose a reason for hiding this comment

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023

briansmith commented Sep 19, 2023

leso-kn commented Sep 19, 2023 • edited Loading

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

briansmith Sep 26, 2023

Choose a reason for hiding this comment

briansmith commented Sep 26, 2023

briansmith commented Sep 27, 2023

briansmith commented Sep 29, 2023

briansmith commented Sep 30, 2023

briansmith commented Sep 30, 2023

leso-kn commented Sep 30, 2023

leso-kn commented Sep 30, 2023

leso-kn commented Sep 30, 2023 • edited Loading

briansmith commented Sep 30, 2023

briansmith Sep 30, 2023

Choose a reason for hiding this comment

briansmith commented Sep 30, 2023

leso-kn commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading

leso-kn commented Sep 30, 2023 •

edited

Loading