Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add code coverage mesurement for powerpc-unknown-linux-gnu. #1877

Merged
merged 1 commit into from
May 7, 2024

Conversation

briansmith
Copy link
Owner

Profiler builtins were added in rust-lang/rust#119404.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (f69e502) to head (69c22b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   96.27%   96.81%   +0.53%     
==========================================
  Files         143      143              
  Lines       20430    20436       +6     
  Branches      226      226              
==========================================
+ Hits        19669    19785     +116     
+ Misses        727      617     -110     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith
Copy link
Owner Author

CI reports the following errors due to undefined symbol __atomic_fetch_add_8:

@ecnelises, do you have any ideas? It seems like we maybe need to change the Rust toolchain to add -latomic to the command line when building with profiler builtins, based on PurpleI2P/i2pd#285 (comment) and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81283? Or maybe otherwise implement the profiler builtins in a different way that doesn't require __atomic_fetch_add_8?

  = note: /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: bss-plt forced due to /home/runner/work/ring/ring/target/powerpc-unknown-linux-gnu/debug/deps/ring-b2bcec301c9e8d00.101za323lune3mo6.rcgu.o
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/target/powerpc-unknown-linux-gnu/debug/deps/ring-b2bcec301c9e8d00.101za323lune3mo6.rcgu.o: in function `<ring::aead::chacha::Key>::new':
          /home/runner/work/ring/ring/src/aead/chacha.rs:40: undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/target/powerpc-unknown-linux-gnu/debug/deps/ring-b2bcec301c9e8d00.101za323lune3mo6.rcgu.o: in function `<ring::aead::chacha::Key>::encrypt_in_place':
          /home/runner/work/ring/ring/src/aead/chacha.rs:48: undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/target/powerpc-unknown-linux-gnu/debug/deps/ring-b2bcec301c9e8d00.101za323lune3mo6.rcgu.o: in function `<ring::aead::chacha::Key>::encrypt_iv_xor_in_place':
          /home/runner/work/ring/ring/src/aead/chacha.rs:55: undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/src/aead/chacha.rs:55: undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/src/aead/chacha.rs:55: undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc-cross/powerpc-linux-gnu/11/../../../../powerpc-linux-gnu/bin/ld: /home/runner/work/ring/ring/target/powerpc-unknown-linux-gnu/debug/deps/ring-b2bcec301c9e8d00.101za323lune3mo6.rcgu.o:/home/runner/work/ring/ring/src/aead/chacha.rs:78: more undefined references to `__atomic_fetch_add_8' follow

@briansmith
Copy link
Owner Author

See also rust-lang/rust#69689 (comment) for another potential avenue to explore.

@briansmith
Copy link
Owner Author

@briansmith
Copy link
Owner Author

I have now implemented a workaround to get this to link, and Codecov.io reports that now the 32-bit specific AES and GCM code is now covered.

@briansmith briansmith merged commit 078369b into main May 7, 2024
148 checks passed
@briansmith briansmith deleted the b/powerpc-coverage branch May 7, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant