Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use llvm-tools-preview instead of external llvm-tools for symbol prefix testing #1908

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

briansmith
Copy link
Owner

@briansmith briansmith commented Jan 13, 2024

See individual commit messages for details. This makes the script portable to all hosts and allows us to expand the symbol prefix checking to all tested targets. It also allows us to avoid incompatibilities between Apple nm and the toolchain's output.

@briansmith briansmith self-assigned this Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e50503) 96.02% compared to head (3cb66f5) 96.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1908   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         136      136           
  Lines       20776    20776           
  Branches      226      226           
=======================================
  Hits        19950    19950           
  Misses        792      792           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith
Copy link
Owner Author

https://github.com/briansmith/ring/actions/runs/7515538763/job/20459551889 is a run that intentionally breaks symbol prefixing, to test this.

@briansmith
Copy link
Owner Author

It looks like the Windows builds are using PowerShell to run the shell script, and "passing" even though they aren't doing any work. :( I'll need to update this to force the use of mingw bash for windows.

@briansmith briansmith force-pushed the b/llvm-tools branch 3 times, most recently from b1de080 to 4166c29 Compare January 14, 2024 01:18
@briansmith
Copy link
Owner Author

It looks like the Windows builds are using PowerShell to run the shell script, and "passing" even though they aren't doing any work. :( I'll need to update this to force the use of mingw bash for windows.

Well, after that, it seems more work is needed for Windows. Will split the Windows work off into a separate issue/PR.

@briansmith
Copy link
Owner Author

https://github.com/briansmith/ring/actions/runs/7516068245 is the new test run to make sure CI fails when an unprefixed symbol exists.

@briansmith
Copy link
Owner Author

https://github.com/briansmith/ring/actions/runs/7516194196 was the final test run that shows that the builds break when there is an unprefixed symbol.

@briansmith briansmith merged commit d8e55e2 into main Jan 14, 2024
140 checks passed
@briansmith briansmith deleted the b/llvm-tools branch January 14, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant