build.rs: De-duplicate AsmTarget
#1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
changed the title
AsmTarget`AsmTarget
briansmith
force-pushed
the
b/dry-asmformat
branch
2 times, most recently
from
1cdfe00
to
976abeb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
=======================================
Coverage 96.29% 96.30%
=======================================
Files 135 135
Lines 20663 20663
Branches 226 226
=======================================
+ Hits 19898 19899 +1
Misses 730 730
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. |
Simplify `AsmTarget` and clarify the logic regarding when and how to use nasm.
briansmith
force-pushed
the
b/dry-asmformat
branch
from
976abeb
to
4f5276e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.