add: GlowLayer declarative inclusion list test

brianzinn · Aug 6, 2021 · 7f82c35 · 7f82c35
1 parent 41173f5
commit 7f82c35
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 4 deletions.
diff --git a/test/hostConfig.spec.ts b/test/hostConfig.spec.ts
@@ -5,7 +5,7 @@ import { CreatedInstance } from '../src/CreatedInstance';
 import { CustomProps } from '../src/CustomProps';
 import renderer, { Container } from '../src/ReactBabylonJSHostConfig';
 import { Engine, FreeCamera, Mesh, NullEngine, PBRMaterial, Scene, StandardMaterial, Vector3 } from '@babylonjs/core';
-import { CameraLifecycleListener, FallbackLifecycleListener, NodeLifecycleListener } from '../src/customHosts';
+import { AbstractMeshLifecycleListener, CameraLifecycleListener, FallbackLifecycleListener } from '../src/customHosts';
 import { PBRClearCoatConfiguration } from '@babylonjs/core/Materials/PBR/pbrClearCoatConfiguration';
 
 describe(' > Reconciler tests', function testSuite() {
@@ -78,7 +78,7 @@ describe(' > Reconciler tests', function testSuite() {
     assert.ok(logger.notCalled, 'console.warn should not be called.');
   });
 
-  it('Create box (Mesh) should be assigned NodeLifecycleListener', async function test() {
+  it('Create box (Mesh) should be assigned AbstractMeshLifecycleListener', async function test() {
     const container = getRootContainerInstance();
 
     const createdInstance: CreatedInstance<any> | undefined = renderer.createInstance('box', {
@@ -88,7 +88,7 @@ describe(' > Reconciler tests', function testSuite() {
 
     assert.notStrictEqual(createdInstance, undefined);
     assert.notStrictEqual(createdInstance!.lifecycleListener, undefined);
-    assert.ok(createdInstance?.lifecycleListener instanceof NodeLifecycleListener, `expecting node lifecycle listener: ${createdInstance?.lifecycleListener}`);
+    assert.ok(createdInstance?.lifecycleListener instanceof AbstractMeshLifecycleListener, `expecting node lifecycle listener: ${createdInstance?.lifecycleListener}`);
   });
 
   it('Create "assignFrom" should defer construction and included delayed creation props', async function test() {

diff --git a/test/render.spec.tsx b/test/render.spec.tsx
@@ -1,5 +1,5 @@
 import React from 'react';
-import { AbstractMesh, ArcRotateCamera, Camera, Color4, Engine, NullEngine, Scene, Vector3 } from "@babylonjs/core";
+import { AbstractMesh, ArcRotateCamera, Camera, EffectLayer, Engine, GlowLayer, NullEngine, Scene, Vector3 } from "@babylonjs/core";
 import sinon from "sinon";
 import assert from 'assert';
 
@@ -142,4 +142,43 @@ describe(' > Reconciler/Render tests', function testSuite() {
     assert.ok(camera instanceof ArcRotateCamera, 'Should be ArcRotateCamera');
     assert.ok(Vector3.Up().equals(camera.target), 'should be the same as Vector3.Up');
   })
+
+  it('GlowLayer should include children to inclusion list (when configured).', async function test() {
+    const container: Container = getRootContainerInstance();
+    const reconciler: ReconcilerInstance = createReconciler({});
+
+
+    const sceneGraph = (
+      <SceneContext.Provider value={{
+        scene: container.scene,
+        sceneReady: true
+      }}>
+          <arcRotateCamera name='camera1' alpha={0} beta={Math.PI / 3} radius={10} target={Vector3.Zero()} />
+          <hemisphericLight name='light1' direction={Vector3.Up()} />
+          <glowLayer name='glow1' addIncludeOnlyChildren>
+            <box
+              name="box"
+              size={2}
+              position={new Vector3(0, 1.2, 0)}
+            >
+              <standardMaterial name='boxMat' />
+            </box>
+          </glowLayer>
+
+      </SceneContext.Provider>
+    )
+    reconciler.render(sceneGraph, container, () => { /* empty for now */ }, null)
+
+    const box: AbstractMesh | undefined = container.scene.meshes.find(m => m.name === 'box');
+    assert.ok(box !== undefined)
+
+    const effectLayers: EffectLayer[] = container.scene.effectLayers;
+    assert.strictEqual(1, effectLayers.length, 'glow layer should be part of scene');
+    assert.ok(effectLayers[0] instanceof GlowLayer);
+
+    const glowLayer: GlowLayer = effectLayers[0] as GlowLayer;
+    assert.ok(glowLayer.hasMesh(box));
+    assert.strictEqual((glowLayer as any)._includedOnlyMeshes.length, 1);
+    assert.strictEqual((glowLayer as any)._includedOnlyMeshes[0], box.uniqueId);
+  })
 })