Fixing "color" inconsistency ("ggrepel") and error for nodes=2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 28, 2017 10:53
Change "color" to "colour" to be consistent with "grepel" and ggplot2 and avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and avoid a warning for "segment.color"
In the default function parameter "x" doesn't exist yet, it is replaced with "model". When the number of nodes is two, the condition "(nrow(edges[, 1:2]) > nrow(unique(edges[, 1:2])))" cannot be assessed. This is fixed using "drop" argument in data.frame/matrix extractor.
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and to avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and to avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and to avoid a warning for "segment.color"
Change "color" to "colour" to be consistent with "ggrepel" and ggplot2 and to avoid a warning for "segment.color"
Bad editing the first time.
briatte
reviewed
Jun 29, 2019
R/fortify-network.R
Outdated
| @@ -199,7 +199,6 @@ fortify.network <- function(model, data = NULL, | |||
| # add missing columns to nodes data | |||
| nodes$xend = nodes$x | |||
| nodes$yend = nodes$y | |||
| names(nodes) = names(edges)[1:ncol(nodes)] | |||
There was a problem hiding this comment.
@mcanouil This line is the only one that I did not get straight away in your PR. No idea why it's not needed any more, I'll just trust you on that :)
There was a problem hiding this comment.
If I recall properly, it was something about the fact that nodes cannot have more columns than the number of edges (but it's been a while and a lot of the packages on which ggnetwork relies on have changed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both ggplot2 and ggrepel use "colour", a warning occures when using "segment.color".
Fixing an issue in fortify.network for nodes=2, in which case, the matrix/data.frame structure was dropped. Issue solved by using "drop" argument.
Fixing issue in fortify.network when no edges.