Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to address the issue when your list of edges has only 1 … #24

Closed
wants to merge 1 commit into from

Conversation

zachcp
Copy link

@zachcp zachcp commented Sep 12, 2017

…entry

I just ran into an issue where the fortify was failing when the edge list of one row. I'm not sure this is the best way to handle the issue but I wanted to provide a possible solution. the issue is that edges[, 1:2] will return a vector instead of a data frame which will cause nrow to throw an error.

…entry

I just ran into an issue where the fortify was failing when the edge list of one row. I'm not sure this is the best way to handle the issue but I wanted to provide a possible solution. the  issue is that  `edges[, 1:2]` will return a vector instead of a data frame which will cause `nrow` to throw an error.
@briatte briatte added this to the v0.5.6 – CRAN update milestone Jun 27, 2019
@briatte
Copy link
Owner

briatte commented Jun 29, 2019

Hi @zachcp

All apologies for not answering your PR earlier.

The problem has been fixed by PR #20.

@briatte
Copy link
Owner

briatte commented Jul 27, 2019

Hi @zachcp

Your PR just helped me solve the issue you raised, again.

I would like to add you to the contributors of the ggnetwork package: may I use your full name (Zachary Charlop-Powers), your academic affiliation (Laboratory of Genetically Encoded Small Molecules, The Rockefeller University, New York, NY, USA) and your professional website for that, please?

Please also let me know if you have an ORCID id. ORCID = 0000-0001-8816-4680

Again, apologies for the very slow work on this package.

@zachcp
Copy link
Author

zachcp commented Jul 29, 2019

Thanks @briatte , thats very kind of you. You may use the information as listed.

briatte added a commit that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants