Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge attributes not converted to factors #55

Closed
briatte opened this issue Jul 30, 2019 · 0 comments
Closed

Edge attributes not converted to factors #55

briatte opened this issue Jul 30, 2019 · 0 comments
Assignees
Labels

Comments

@briatte
Copy link
Owner

briatte commented Jul 30, 2019

The problems described in #53 and #54 have a little cousin:

return(unique(rbind(nodes, edges[!is.na(edges$xend), ])))

rbind uses the types of the first argument (here nodes) to determine the types of the second one. This causes edge attributes of class character to never be returned as factors, even if the user asks so (which is the default: see #53).

The problem affects both fortify.network and fortify.igraph.

The arguments passed to rbind need to be reversed, which will affect the result of ggnetwork but should not affect plots produced with it.

@briatte briatte added the bug label Jul 30, 2019
@briatte briatte added this to the v0.5.4 – igraph milestone Jul 30, 2019
@briatte briatte self-assigned this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant