Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toggle between light/dark mode separate from theme #92

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

michael-pratt
Copy link
Contributor

Proposed solution for Issue #85 (this replaces closed PR #87).

@michael-pratt michael-pratt marked this pull request as ready for review November 4, 2022 21:27
Copy link
Owner

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bric3 bric3 merged commit 65b0785 into bric3:main Dec 7, 2022
@bric3
Copy link
Owner

bric3 commented Dec 7, 2022

Sorry for the late feedback, thanks for the changes !

@michael-pratt
Copy link
Contributor Author

No worries, thanks!

@LintaoAmons
Copy link

How to toggle the light mode?

@michael-pratt
Copy link
Contributor Author

How to toggle the light mode?

There is a new button on the editor window to toggle it. I don't believe a new version has been released with this change, however, so you'll need to build off main.

@LintaoAmons
Copy link

Thanks~ I'll try

@bric3 bric3 added this to the next milestone Dec 16, 2023
@bric3 bric3 modified the milestones: next, 0.4.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants