New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assertion equals and ProviderChainTest #29

Merged

BenMorel merged 1 commit into brick:master from open-source-contributions:assertion_enhancement

Aug 25, 2020

Contributor

peter279k commented Aug 25, 2020

Changed log

Using the assertSame to make value equals assertion strict.
The ProviderChainTest.php class should change into Brick\Money\Tests\ExchangeRateProvider namespace.


          Improve assertion equals and ProviderChainTest

bdc7013

BenMorel merged commit 5fc7c59 into brick:master

Member

BenMorel commented Aug 25, 2020

Good find, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment