Merge into master from #126 pr commits #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor for DAO::JobExecution * Replace upsert to create for job execution when execute job * Replace where expression when select job_execution from subsystem/job_name to job_execution_id * Modify task specification to add job_execution info but has changed specification about @Queue * Add custom exception class for lock methods * Modify error message for embedding * Change timing of lock/unlock job * Refactor variable name to record(s) * Revert to copy constant * Separate JobTask into JobTask and JobExecutionTask for DatabaseTaskQueue * Modify test of DatabaseTaskQueue for JobExecutionTask class and refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#124 を前提として書いていた #126 の内容をmasterにマージするためのPRです
#126 マージ後の
replace_lock_info_to_executor_infoブランチをcheckout してgit rebase masterしました。テスト、ローカルでの実行ともに問題ないことを確認済みです。また、コード変更内容を見た限りでは f27d7ca による変更がそのままきており、approve済みの内容です。