Fix for group doubleList manager bug. Spotted by Alexander Ling.

bricoleurs · Nov 26, 2003 · 2974afb · 2974afb
1 parent 89e5a56
commit 2974afb
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/comp/widgets/help/debuggers.html b/comp/widgets/help/debuggers.html
@@ -31,4 +31,5 @@
   <li>Gary Gilchrist</li>
   <li>Creighton Higgins</li>
   <li>Earle Martin</li>
+  <li>Alexander Ling</li>
 </ul>
diff --git a/lib/Bric/Biz/Person/User.pm b/lib/Bric/Biz/Person/User.pm
@@ -8,18 +8,18 @@ Bric::Biz::Person::User - Interface to Bricolage User Objects
 
 =head1 VERSION
 
-$Revision: 1.25 $
+$Revision: 1.26 $
 
 =cut
 
 # Grab the Version Number.
-our $VERSION = (qw$Revision: 1.25 $ )[-1];
+our $VERSION = (qw$Revision: 1.26 $ )[-1];
 
 =pod
 
 =head1 DATE
 
-$Date: 2003-09-16 04:44:46 $
+$Date: 2003-11-26 15:21:08 $
 
 =head1 SYNOPSIS
 
@@ -1428,13 +1428,17 @@ $get_em = sub {
             $wheres .= " AND u.id = c2.object_id AND c2.member__id = m2.id" .
               " AND m2.active = 1 AND m2.grp__id = ?";
             push @params, $v;
+        } elsif ($k eq 'active') {
+            $wheres .= " AND u.$k = ?";
+            push @params, $v ? 1 : 0;
         } else {
             $wheres .= " AND LOWER(p.$k) LIKE ?";
             push @params, lc $v;
         }
     }
 
-    $wheres .= ' AND u.active = 1' unless defined $args->{id};
+    $wheres .= ' AND u.active = 1' unless defined $args->{id}
+      or exists $args->{active};
     my ($qry_cols, $order) = $ids ? (\'DISTINCT u.id', 'u.id') :
       (\$sel_cols, 'LOWER(p.lname), LOWER(p.fname), LOWER(p.mname), u.id');
 

diff --git a/lib/Bric/Changes.pod b/lib/Bric/Changes.pod
@@ -147,6 +147,11 @@ elements can type in the key name field. Thanks to Arthur for the spot!
 The Template toolkit burner now correctly uses element key names instead of
 names to find corresponding templates. [David]
 
+=item *
+
+Management of user groups in a double list manager UI no longer causes an SQL
+error. Spotted by Alexander Ling. [David]
+
 =back
 
 =head1 VERSION 1.7.0 (2003-10-22)

diff --git a/lib/Bric/License.pod b/lib/Bric/License.pod
@@ -227,6 +227,8 @@ Friends who have spotted bugs include:
 
 =item Earle Martin
 
+=item Alexander Ling
+
 =back
 
 Bricolage's translation team: