Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowball and sword item presets #28

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

Chikorita-Lover
Copy link
Member

No description provided.

@Joelant05 Joelant05 self-requested a review September 5, 2022 12:07
Copy link
Member

@Joelant05 Joelant05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the snowball preset look good.
With the sword preset, you've added the item_texture.json creation to the manifest, however this is already handled in the itemImages.js preset script; once that is removed I should be ok to merge this
Thanks!

@Chikorita-Lover
Copy link
Member Author

Gotcha, I'll get to that as soon as possible!

@Chikorita-Lover
Copy link
Member Author

I forgot to do this, so it's a bit later than I could've done it. But it should be done and ready to merge!

Copy link
Member

@Joelant05 Joelant05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now thanks!

@Joelant05 Joelant05 merged commit fad54f7 into bridge-core:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants