Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming files fails #580

Closed
Q2114 opened this issue Aug 21, 2022 · 16 comments · Fixed by #751
Closed

Renaming files fails #580

Q2114 opened this issue Aug 21, 2022 · 16 comments · Fixed by #751
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Q2114
Copy link

Q2114 commented Aug 21, 2022

Hello, I found 2 bugs.
-1:
Bug with folder/file renaming. Bridge does not save the changed file/folder name. Video below ↓
https://youtube.com/shorts/r8RG4dvrJMM?feature=share

-2:
The bug is that the bridge cannot delete files from the modification. Video also below ↓
https://youtu.be/jAxyQ9Ok54U

  • OS: [WEB Chrome / Android 11]
  • App Version: [2.3.1]
@Q2114 Q2114 added the bug Something isn't working label Aug 21, 2022
solvedDev added a commit that referenced this issue Aug 22, 2022
@solvedDev solvedDev added this to the v2.3.X milestone Aug 22, 2022
@solvedDev solvedDev self-assigned this Aug 22, 2022
@solvedDev solvedDev added the cannot reproduce Further information is requested label Aug 23, 2022
@solvedDev
Copy link
Member

I cannot reproduce the second error but maybe that one was already fixed by the commit fixing #573

@solvedDev
Copy link
Member

Thanks for the great bug report (including the videos) btw! That was extremely helpful :)

@Q2114
Copy link
Author

Q2114 commented Aug 23, 2022

The bugs remain... Video below ↓
https://youtu.be/ae3842NZbYE

Chrome browser version:
IMG_20220823_142427

@solvedDev
Copy link
Member

We did not roll out a new update yet.

@Q2114
Copy link
Author

Q2114 commented Aug 23, 2022

Oh, I'm sorry... XD

@Q2114
Copy link
Author

Q2114 commented Aug 23, 2022

Thanks for the app :)

@solvedDev
Copy link
Member

Np, v2.3.2 is rolling out now.

@Q2114
Copy link
Author

Q2114 commented Aug 23, 2022

Ok, I'll wait :3

@Q2114
Copy link
Author

Q2114 commented Aug 23, 2022

Greetings, there is no more bug with deleting files!
But the bug with renaming files remained. Bridge never renames files. Video : https://youtu.be/gE3ObJs09gE
Thanks

@solvedDev solvedDev reopened this Aug 25, 2022
@solvedDev
Copy link
Member

We fixed a few issues with our file system with v2.3.5. Can you take a look at whether your issue is fixed now?

@Q2114
Copy link
Author

Q2114 commented Oct 16, 2022

Good evening. Yes, I took a video. But the file renaming error remained, maybe it's a problem with my smartphone...? I don't even know ._."

https://youtu.be/QkSFvNFJsOI

@solvedDev
Copy link
Member

Thank you!

@Joelant05 I cannot reproduce this issue on my phone, can you try reproducing it when you find the time?

@solvedDev solvedDev changed the title [BUG] "Delete error" / "Rename error" "Rename error" Oct 16, 2022
@solvedDev solvedDev changed the title "Rename error" Renaming files fails Oct 16, 2022
@solvedDev
Copy link
Member

Small bump @Joelant05

@Joelant05
Copy link
Member

Yeah sure. I completely missed this, will take a look now

@Joelant05
Copy link
Member

I can reproduce the issue, it may be related to the issue we had with the tree editor inputs, since the keyboard shows "Next" instead of the regular enter button. Clicking off instead of pressing "Next" has the same issue also.

Screenshot_20221204-164308_Chrome.jpg

@solvedDev
Copy link
Member

Oh, that's a good catch. Thanks a lot! Let me hack together a PR real quick :D

@solvedDev solvedDev removed the cannot reproduce Further information is requested label Dec 4, 2022
solvedDev added a commit that referenced this issue Dec 4, 2022
@solvedDev solvedDev linked a pull request Dec 4, 2022 that will close this issue
Joelant05 added a commit that referenced this issue Dec 5, 2022
closes #580

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>
solvedDev added a commit that referenced this issue Dec 9, 2022
* upd: v1.19.50 is stable now

* upd: remove experimental requirement for set_property event response

* upd(DocScraper): change documentation fetch url

* upd: filter undefined_test_only from identifiers

* fix: remove unnecessary border-radius

* feat: native bridge. v2 builds (#740)

* feat: initial tauri integration

* fix: build problems

* fix: disable service worker for tauri

* fix: use version from package.json

* fix: build error

* fix: tauri action

* fix: build command

* v2.4.2

* fix: product name

* v2.4.3

* fix: deploy script

* v2.4.4

* upd: app icon

* v2.4.5

* feat: custom update flow

* upd: vite config

* upd: no pointer events on toolbar title

* upd: tauri configuration

* v2.4.6

* fix: build error

* fix: disable updater dialog

* v2.4.7

* fix: enable window decorations on windows again

* upd: improve custom update flow

* upd: faster data loading

* feat: discord rpc support

* upd: change comment

* feat: reveal in file explorer

* upd: change discord rpc logo

* feat: reload app shortcut

* feat(VirtualFs): WIP support for arbitrary backing stores

Still need to get comlink serde back running. TauriFsStore needs testing

* feat: comlink virtual fs serde

* feat: initial working version of native fs integration

* fix: disable save warning for tauri build

* fix: make proper project chooser available

* fix: disable quick export

* fix: disable project save action

* feat: faster dash builds

* upd: version

* feat(saveOrDownload): use reveal_in_file_explorer

* fix(RevealInFileExplorer): do not panic on linux

* feat: support com.mojang syncing
Supports automatically inferring com.mojang directory location on windows.

* feat: support for setting com.mojang folder

* upd: TauriSetup is no longer required

* fix: build error

* fix: close compiler window after linking folder

* upd: make "Link Folder" translatable

* v2.4.8

* fix: web app build error

* fix: revealInFileExplorer action

* fix: duplicated menu bar on window

* fix(Toolbar): only add padding on macos

* fix(Toolbar): bridge logo display

* feat: debug display for com.mojang folder location

* fix(HomeView): hide choose folder btn for tauri builds

* fix: errors upon updating data

* fix: use dynamic import

* v2.4.9

* fix: paths on windows

* v2.4.10

* fix: more issues with paths on windows

* upd: linked folder path display

* v2.4.11

* upd: contribution instructions for native builds

* fix: dash now works on windows

* feat: custom title bar on windows

* v2.4.12

* fix: window controls showing on wrong platforms

* v2.4.13

* feat: faster schema script generation
towards #746

* feat: faster component schema generation
towards #746
Also changes component generation to use a new version of dash for better performance.

* upd: speed up iterating directory contents

* fix: disable com.mojang drop on tauri build

* feat: enable open folder for tauri builds

* feat: warn before closing with unsaved changes

* upd: updater URL

* fix(StartScreen): make bridge. logo draggable

* fix: brproject exports

* fix: tauri downloads

* v2.4.14

* fix(Vite): don't watch src-tauri

* upd: disable move to local project action on tauri builds

* upd: open project folder action now use reveals in file explorer

* fix: error upon using force data download option

* upd: slightly improve perf of memoryStore.has(...)

* fix: dash watch mode works now

* v2.4.15

* fix: type error

* upd: improve shareFile function

* feat: solid views (#753)

* feat: initial support for embedding SolidJS

* upd: test code

* feat: WIP directory viewer rewrite

* fix(Vue): render SolidView only once

* fix: ripple color in light mode

* feat(SolidCompat): toVue utility function

* fix: disable useIcon helper for solid

* fix: type error

* fix: type error

* fix: duplicated entries within virtual fs (#752)

* fix: duplicated entries within virtual fs

* upd: add comment

* fix: rename files on mobile (#751)

closes #580

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>

* fix(IndexedDb): format compat (#750)

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>

* upd: use last modified timestamp (#749)

* upd: use last modified timestamp

* fix: correctly register Rust functions

fixes this PR from breaking "reveal_in_file_explorer"

* upd: remove unnecessary type assertion

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>

* upd(SetupView): change local message to indicate next steps
(Hint towards creating a new project)

* fix(SetupView): disable com.mojang step for tauri builds

* feat(tauri): import projects (#756)

* feat: import projects

* fix: remove unused import

* feat: open with snowstorm (#754)

* fix: lang key

* feat: fast directory copying (#761)

* feat: fast directory copying

* upd: copyFolder should also use fast path

* fix: inactive tab display (#763)

* feat: fast path for getDirectoryHandle (#760)

* feat(tauri): fast path for getDirectoryHandle

* feat: fast get directory handle for indexed db

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>

* upd: simpler PR template

* fix: openInSplitScreen (#768)

* feat: import multiple projects (#767)

* v2.5.0

* feat: terminal (#755)

* feat: WIP terminal

* upd: progress on terminal
- upd: support stderr
- upd: move UI to solid

* feat: cwd support
Support the "cd" command and display the cwd within the terminal UI

* feat: add new bottom panel UI
Move WIP terminal into the bottom panel

* fix: bottom panel padding

* feat: allow disabling ripple

* fix: bottom panel overflow style

* upd: decrease ripple opacity

* upd: WIP compiler logs tab

* feat: SolidIconButton component

* fix: issue with tab bar

* feat: import terminal on demand

* feat(TabBar): scale transition

* fix: bottom panel open button position

* feat: make compiler tab work

* upd(CompilerPanel): improve margin logic

* upd: BottomPanel

* feat(BottomPanel): now uses translation files

* fix: add padding between scrollbar and panel content

* fix: bottom panel layout with welcome screen & split screen

* fix: add drop shadow to command bar menu

* fix: remove unused component

* fix: remove unused component

* feat: use global app state for child processes

* upd: move commands to fs_extra module

* upd: use tokio

* feat: finish terminal

* upd: tweak terminal style

* upd: tweak text field styles

* fix: margin issues around bottom panel

* upd: disable bottom panel by default

* fix: error upon accessing particle texture

* upd: replace ANSI color codes

* fix: scrollbar overflow

* fix: typo

* feat: dynamic type loading (#758)

* feat: dynamic type loading

* upd: WIP data package

for testing this PR

* upd: complete data package

Again, for testing. I'll push this to editor-packages when this PR is merged

* upd: rewrite caching logic to be more reliable

cache is now updated once after everything has been fetched

* upd: bump mc-project-core

* upd: minor changes
- fix: error upon failing to fetch types
- upd: negate logic to flatten code structure

Co-authored-by: solvedDev <solvedDev@gmail.com>

* fix: type error

* feat: new type format

closes #710

* upd: data to latest preview

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

3 participants