Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rounded windows on mobile #652

Merged
merged 2 commits into from
Oct 16, 2022
Merged

fix: rounded windows on mobile #652

merged 2 commits into from
Oct 16, 2022

Conversation

solvedDev
Copy link
Member

Windows shouldn't be rounded on mobile as they're fullscreen by default.

@solvedDev solvedDev added the bug Something isn't working label Oct 15, 2022
@solvedDev solvedDev added this to the v2.3.X milestone Oct 15, 2022
@stackblitz
Copy link

stackblitz bot commented Oct 15, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@solvedDev solvedDev changed the base branch from main to dev October 15, 2022 20:19
@Joelant05
Copy link
Member

After this change, I am still noticing rounded corners in windows on mobile.
image

@solvedDev
Copy link
Member Author

Good catch, thanks!

@solvedDev solvedDev merged commit 45fe411 into dev Oct 16, 2022
@solvedDev solvedDev deleted the fix/window-rounded-on-mobile branch October 16, 2022 11:28
solvedDev added a commit that referenced this pull request Oct 16, 2022
## Features:
- Infer file path for imported sound files correctly (bridge-core/editor-packages#29)
- Ability to refresh folder within the  (#659)

## Changes:
- Added "1.19.50" format version (ea61a76)
- Optimized directory copying (#650)

## Fixes:
- Fixed wrong file extension being appended upon exporting project on Android (#655)
- Fixed wrong icon color for ImageTab (#657)
- Removed rounded window corners on mobile (#652)
- Fixed project exports (#661)

Co-authored-by: Joelant05 <64587014+Joelant05@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants