Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopilot buffer size #58

Closed
MaxouPicsou opened this issue Oct 5, 2023 · 2 comments
Closed

Autopilot buffer size #58

MaxouPicsou opened this issue Oct 5, 2023 · 2 comments

Comments

@MaxouPicsou
Copy link
Contributor

While testing the autopilot functionality I realized that my NMEA frames were not interpreted. While debugging, I noticed that there was a problem with the buffer size and only my first 8 characters were taken into account.

Autopilot was limited to a buffer size of 8 because of the next line:

ssize_t nread = ::read(rcvSocket.native_handle(), buf, sizeof(buf));

sizeof(buf) = 8 because it returns the size of type char * which is a pointer and not a tab size of 128 that was expected.

I push a commit and a pull request.

@MaxouPicsou
Copy link
Contributor Author

fb2f6b2

@bridgecommand
Copy link
Owner

Thanks, I have merged the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants