Include prisma_api_url and keys #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Apr 12, 2023
| @@ -155,3 +174,6 @@ runs: | |||
| BITBUCKET_TOKEN: ${{ inputs.bitbucket_token }} | |||
| BITBUCKET_USERNAME: ${{ inputs.bitbucket_username }} | |||
| BITBUCKET_APP_PASSWORD: ${{ inputs.bitbucket_app_password }} | |||
| PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} | |||
There was a problem hiding this comment.
Suggested change
| PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} | |
| PRISMA_API_URL: ${{ inputs. prisma_api_url }} |
|
@Juliandreslopez Hey, are you still planning on fixing the issue? |
billyjbryant
reviewed
Dec 8, 2023
| @@ -155,3 +174,6 @@ runs: | |||
| BITBUCKET_TOKEN: ${{ inputs.bitbucket_token }} | |||
| BITBUCKET_USERNAME: ${{ inputs.bitbucket_username }} | |||
| BITBUCKET_APP_PASSWORD: ${{ inputs.bitbucket_app_password }} | |||
| PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} | |||
| PRISMA_ACCESS_KEY: ${{ secrets.PRISMA_CLOUD_ACCESS_KEY }} | |||
There was a problem hiding this comment.
I would refrain from hard-coding a requirement on secrets into the action and instead take required data as an input where a secret can be used if so desired. Additionally, the prisma api key and secret are ingestible already via the api-key input in the format of <ACCESS_KEY>::<SECRET_KEY>.
|
Please be sure to document usage in the README.md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.