Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive CKV_SECRET_6 #3487

Closed
Hayden289 opened this issue Sep 7, 2022 · 1 comment
Closed

False positive CKV_SECRET_6 #3487

Hayden289 opened this issue Sep 7, 2022 · 1 comment
Labels
checks Check additions or changes secrets

Comments

@Hayden289
Copy link

Hayden289 commented Sep 7, 2022

Describe the issue
If it is related to an existing check, please note the relevant check ID.
Also, explain the logic for this addition / change.

CKV_SECRET_6 fails for a specific property and string combination: secret_name = "TF_TEAM_TOKEN"

I don't think a key of secret_name should trigger an entropy check on its value. It's likely rare but this shows there are fairly simple names which will fail the entropy check.

Examples
Please share an example code sample (in the IaC of your choice) + the expected outcomes.

echo 'secret_name = "TF_TEAM_TOKEN"' > config.txt
checkov -f config.txt

image

Version (please complete the following information):

  • Checkov Version [e.g. 22] 2.0.1200 & 2.1.195

Additional context
It is this specific value that fails the check: "TF_TEAM_TOKEN"
If you change it even slightly it passes.

@Hayden289 Hayden289 added the checks Check additions or changes label Sep 7, 2022
@gruebel gruebel added the secrets label Sep 8, 2022
@nimrodkor
Copy link
Contributor

Hey @Hayden289 !
It seems that this does not reproduce with the current checkov version, 2.2.17.
I believe it was resolved as part of #3575

Closing for now, feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checks Check additions or changes secrets
Projects
None yet
Development

No branches or pull requests

3 participants