fix(secrets): change entropy limit in Combinator plugin #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKK
changed the title
marynaKK
changed the title
gruebel
reviewed
Sep 28, 2022
|
@nimrodkor please verify the tests I added are enough :) |
nimrodkor
reviewed
Sep 28, 2022
|
@nimrodkor does it look OK now? |
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Sep 29, 2022
…#3575) * inital try - 1 test fails * changed the example in the false positive test * indicate the failed test * adjusted limits for relevant files * removed unnessary added plugins * moved both limits to be together * remove comment * change combinator plugin to examine only non-source-code files * undo the last change to combinator plugin * changed the combinator to combine keywords only in Iac, in sc files scan only with high entropy * remove commented code * improved statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Sets a different limit for entropy for the standalone plugin vs. the combinator plugin.
The change would cause finding fewer false positive secrets in source code, but leaves the Iac findings as it.
Checklist: