CKV_DOCKER_3: Additionally check if user is created by gosu #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Jan 27, 2022
| return CheckResult.FAILED, None | ||
| for instruction in conf: | ||
| value = instruction['value'] | ||
| if instruction['instruction'] in self.supported_instructions: |
There was a problem hiding this comment.
I'm surprised you need to check here, that the instruction is one of the supported ones, but maybe my memories are blurry 😄
There was a problem hiding this comment.
I copied this from another test case (UpdateNotAlone.py)
|
@gruebel why was this closed? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #2218
Either USER instruction or CMD/ENTRYPOINT instruction has to be set in order for the check to pass.
CMD/ENTRYPOINT instruction additionally needs
gosuas an argument and 2 more to retain the minimal usage of gosu:Usage: ./gosu user-spec command [args]By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.