Pass ECR Policy with conditional constraint #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Feb 3, 2022
tests/cloudformation/checks/resource/aws/example_ECRPolicy/ECRPolicy-PASSED-2.yaml
Outdated
Show resolved
Hide resolved
…ldcard-With-Condition
…github.com:MooreDerek/checkov into 1582/Allow-ECR-Repo-Policy-Wildcard-With-Condition
gruebel
approved these changes
Feb 5, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2022
* Pass ECR Policy with conditional constraint * Update following Code Review * Added tests for conditional ECR Policy * Fix test count for CloudFormation Co-authored-by: Derek Moore <derek.moore@leaven.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes #1582
Issue 1582 - Allow an AWS ECR Policy to pass with a wildcarded Prinicipal if there is a Principal Org ID constraint conditional statement.