Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gitlab): GitlabCI ImageReferencer #3544

Merged
merged 17 commits into from
Sep 22, 2022
Merged

feat(gitlab): GitlabCI ImageReferencer #3544

merged 17 commits into from
Sep 22, 2022

Conversation

Eliran-Turgeman
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Adding support for ImageReferencer to GitlabCI framework through ImageReferencerMixin.
  • Skip trying to create a report in case inspect on image name has failed and return an empty string.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments, but other than that great work 🚀

checkov/common/runners/base_runner.py Outdated Show resolved Hide resolved
checkov/gitlab_ci/image_referencer/base_provider.py Outdated Show resolved Hide resolved
checkov/gitlab_ci/runner.py Outdated Show resolved Hide resolved
@Eliran-Turgeman
Copy link
Contributor Author

@gruebel I addressed all your comments, thanks! 😄

gruebel
gruebel approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoop, whoop 🎉

checkov/gitlab_ci/image_referencer/manager.py Outdated Show resolved Hide resolved
checkov/gitlab_ci/runner.py Outdated Show resolved Hide resolved
arielkru
arielkru approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@arielkru arielkru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎖️

@Eliran-Turgeman Eliran-Turgeman merged commit b36b650 into master Sep 22, 2022
@Eliran-Turgeman Eliran-Turgeman deleted the gitlab_ci_enable_IR branch September 22, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@arielkru arielkru arielkru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eliran-Turgeman @gruebel @arielkru