Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graph): add support for modules in graph checks #3635

Merged
merged 2 commits into from
Oct 27, 2022
Merged

feat(graph): add support for modules in graph checks #3635

merged 2 commits into from
Oct 27, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 10, 2022 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • added support for modules in graph checks by just adding module to the resource_types field
  • had to fix the 1.5 year old HACK ALERT workaround 馃槃

Fixes #3233

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

tronxd
tronxd approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@tronxd tronxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nimrodkor nimrodkor merged commit 5766041 into bridgecrewio:master Oct 27, 2022
Floodnut pushed a commit to init-cloud/checkov that referenced this pull request Oct 27, 2022
@gruebel @schosterbarak
feat(graph): add support for modules in graph checks (bridgecrewio#3635)
54f3a58 
* add support for modules in graph checks

* fix module skip in plan files
Floodnut pushed a commit to init-cloud/checkov that referenced this pull request Oct 27, 2022
@gruebel @schosterbarak
feat(graph): add support for modules in graph checks (bridgecrewio#3635)
fbd1460 
* add support for modules in graph checks

* fix module skip in plan files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd approved these changes

@nimrodkor nimrodkor nimrodkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to limit module source as a custom policy
3 participants
@gruebel @tronxd @nimrodkor