Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): Enable multiple image referencer framework results in the same scan #3652

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

arielkru
Copy link
Collaborator

@arielkru arielkru commented Oct 12, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Before the PR, sca_image scan results would contain only one framework's result, instead of a list with all the image_cached_results from all image referencer frameworks. This change merges all the reports to be included in the final one.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add or extend a test for it?

checkov/common/output/report.py Show resolved Hide resolved
@arielkru
Copy link
Collaborator Author

@gruebel good idea, added a test

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@arielkru arielkru merged commit 4e5af96 into master Oct 18, 2022
@arielkru arielkru deleted the support-multiple-fw-ir-sca branch October 18, 2022 07:27
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 18, 2022
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants