Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kustomize): stop kustomize run, if there is nothing to process #3681

Merged
merged 2 commits into from
Oct 18, 2022
Merged

feat(kustomize): stop kustomize run, if there is nothing to process #3681

merged 2 commits into from
Oct 18, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 17, 2022 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • if we can't find any kustomize related files, then we don't need to further do anything and can return the report early
  • removed the pip upgrade, which causes errors in Windows builds

Fixes #3673

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Saarett
Saarett approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌹

@gruebel gruebel merged commit abe6ae2 into bridgecrewio:master Oct 18, 2022
@gruebel gruebel deleted the adjust-kustomize branch October 18, 2022 08:32
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 18, 2022
@gruebel @schosterbarak
feat(kustomize): stop kustomize run, if there is nothing to process (b…
993852e 
…ridgecrewio#3681)

* stop kustomize run, if there is nothing to process

* remove pip upgrade
gruebel added a commit to gruebel/checkov that referenced this pull request Oct 18, 2022
@gruebel @schosterbarak
feat(kustomize): stop kustomize run, if there is nothing to process (b…
6c979be 
…ridgecrewio#3681)

* stop kustomize run, if there is nothing to process

* remove pip upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saarett Saarett Saarett approved these changes

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman approved these changes

@ayajbara ayajbara ayajbara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails when using debug in pycharm
4 participants
@gruebel @Saarett @Eliran-Turgeman @ayajbara