Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Add or condition for TLS 1.3 policy, supporting CKV_AWS_103 #3700

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix(terraform): Add or condition for TLS 1.3 policy, supporting CKV_AWS_103 #3700

merged 2 commits into from
Oct 20, 2022

Conversation

theherk
Copy link
Contributor

@theherk theherk commented Oct 19, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

This adds a condition to check that listener policies for the TLS 1.3 policy announced here are indeed "at least" TLS 1.2.

Fixes #3570

New/Edited policies

CKV_AWS_103 is edited to confirm that policy ELBSecurityPolicy-TLS13-1-2-2021-06 is at least TLS 1.2.

Checklist:

  • [✓] My code follows the style guidelines of this project
  • [✓] I have performed a self-review of my own code
  • [✓] I have commented my code, particularly in hard-to-understand areas
  • [✓] I have made corresponding changes to the documentation
  • [✓] I have added tests that prove my feature, policy, or fix is effective and works
  • [✓] New and existing tests pass locally with my changes
  • [✓] Any dependent changes have been merged and published in downstream modules

gruebel
gruebel approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good 🍻

@gruebel gruebel merged commit b060274 into bridgecrewio:master Oct 20, 2022
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 20, 2022
@theherk @schosterbarak
fix(terraform): Add or condition for TLS 1.3 policy, supporting CKV_A…
71a0376 
…WS_103 (bridgecrewio#3700)

* Add or condition for tls 1.3 policy.

* Add tests verifying tls 1.3 meets requirement.
gruebel pushed a commit to gruebel/checkov that referenced this pull request Oct 20, 2022
@theherk @schosterbarak
fix(terraform): Add or condition for TLS 1.3 policy, supporting CKV_A…
b84bb25 
…WS_103 (bridgecrewio#3700)

* Add or condition for tls 1.3 policy.

* Add tests verifying tls 1.3 meets requirement.
@theherk theherk deleted the tf-tls-1-3 branch October 20, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@ayajbara ayajbara ayajbara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CKV_AWS_103 does not support TLS 1.3 security policies
3 participants
@theherk @gruebel @ayajbara