Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): TF Dynamic Blocks support - for_each lists type #3737

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

ChanochShayner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner marked this pull request as ready for review October 26, 2022 07:59
@ChanochShayner ChanochShayner changed the title feat(terraform): TF Dynamic Blocks support lists type feat(terraform): TF Dynamic Blocks support - for_each lists type Oct 27, 2022
Copy link
Contributor

@YaaraVerner YaaraVerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! had one comment :)

block_content = block_values.get("content")
dynamic_values = block_values.get("for_each")
if not block_content or not dynamic_values:
return rendered_blocks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not continue the loop in this case? isn't it possible to have other valid dynamic blocks?

@ChanochShayner ChanochShayner merged commit f65d1b0 into master Oct 27, 2022
@ChanochShayner ChanochShayner deleted the DynamicBlocksSupport branch October 27, 2022 11:00
@ChanochShayner ChanochShayner self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants