Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): pre-validate OpenAPI JSON files #3760

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 29, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • aligned the processing of OpenAPI YAML and JSON files to do a simple pre-validation step
  • adjusted the JSOn parsing to have the same return type as the YAML one
  • removed a couple of round brackets, which are not needed

Fixes #3755

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel merged commit 6eb6508 into bridgecrewio:master Oct 31, 2022
@gruebel gruebel deleted the pre-validate-json-openapi branch October 31, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip JSON files which are not OpenAPI templates to be processed by the OpenAPI framework
3 participants