Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Add CKV_AWS_276 to ensure that API Gateway Method Settings data_trace_enabled is not set to True #3761

Merged
merged 2 commits into from
Nov 2, 2022
Merged

feat(terraform): Add CKV_AWS_276 to ensure that API Gateway Method Settings data_trace_enabled is not set to True #3761

merged 2 commits into from
Nov 2, 2022

Conversation

NickG123
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added a new check that data_trace_enabled in API Gateway Method Settings is not set to True
Not recommended to be enabled by AWS as seen here

Fixes #3693

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@NickG123 NickG123 changed the title Added a new check for API Gateway Method Settings data trace feat(terraform)Added a new check for API Gateway Method Settings data trace Oct 29, 2022
@NickG123 NickG123 changed the title feat(terraform)Added a new check for API Gateway Method Settings data trace feat(terraform): Add CKV_AWS_276 to ensure that API Gateway Method Settings data_trace_enabled is not set to True Oct 29, 2022
gruebel
gruebel reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great work on your first check 🥇 just two minor things, which need some attention.

checkov/terraform/checks/resource/aws/APIGatewayMethodSettingsDataTrace.py Outdated Show resolved Hide resolved
checkov/terraform/checks/resource/aws/APIGatewayMethodSettingsDataTrace.py Outdated Show resolved Hide resolved
@NickG123 @gruebel
Apply suggestions from code review
808755b 
Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
gruebel
gruebel approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🍻

@gruebel gruebel merged commit e731cc6 into bridgecrewio:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@marynaKK marynaKK marynaKK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS API Gateway data_trace_enabled
3 participants
@NickG123 @gruebel @marynaKK