Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): support cross-modules edges #3909

Merged
merged 5 commits into from
Nov 22, 2022
Merged

feat(terraform): support cross-modules edges #3909

merged 5 commits into from
Nov 22, 2022

Conversation

YaaraVerner
Copy link
Contributor

@YaaraVerner YaaraVerner commented Nov 21, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Support cross-variable edges of resources that are connected via modules.
Implementing issue-3886

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@YaaraVerner YaaraVerner marked this pull request as ready for review November 22, 2022 09:17
@YaaraVerner YaaraVerner merged commit 59692f6 into master Nov 22, 2022
@YaaraVerner YaaraVerner deleted the add-terraform-cross-modules-edges branch November 22, 2022 12:28
gruebel pushed a commit to gruebel/checkov that referenced this pull request Nov 22, 2022
@YaaraVerner @actions-user
feat(terraform): support cross-modules edges (bridgecrewio#3909)
706e816 
* support cross-modules edges

* fix getting the source modules

* fix test

* add UT
gruebel pushed a commit to gruebel/checkov that referenced this pull request Nov 22, 2022
@YaaraVerner @actions-user
feat(terraform): support cross-modules edges (bridgecrewio#3909)
b0ac8df 
* support cross-modules edges

* fix getting the source modules

* fix test

* add UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd approved these changes

@rotemavni rotemavni rotemavni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaaraVerner @tronxd @rotemavni