Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): better check names to avoid confusion - addresses #3912 #3921

Merged
merged 1 commit into from Nov 24, 2022

Conversation

JamesWoolfenden
Copy link
Contributor

@JamesWoolfenden JamesWoolfenden commented Nov 23, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3912

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JamesWoolfenden JamesWoolfenden marked this pull request as ready for review November 23, 2022 08:45
@rotemavni rotemavni merged commit 288927f into master Nov 24, 2022
@rotemavni rotemavni deleted the fix/betternaming branch November 24, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate checks CKV_K8S_29 and CKV_K8S_30 ?
3 participants