Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Azure use signed image in ACR #3923

Merged
merged 3 commits into from Nov 27, 2022
Merged

Conversation

JamesWoolfenden
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JamesWoolfenden JamesWoolfenden changed the title feature(Terraform): Azure use signed image in ACR feature(terraform): Azure use signed image in ACR Nov 23, 2022
@JamesWoolfenden JamesWoolfenden changed the title feature(terraform): Azure use signed image in ACR feat(terraform): Azure use signed image in ACR Nov 23, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@nimrodkor nimrodkor changed the base branch from master to main November 27, 2022 07:42
@nimrodkor nimrodkor merged commit 075c311 into main Nov 27, 2022
@nimrodkor nimrodkor deleted the feature/ACRSigning branch November 27, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants