Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sca): fix related resource id for helm and kustomize #3931

Merged
merged 1 commit into from Nov 24, 2022
Merged

fix(sca): fix related resource id for helm and kustomize #3931

merged 1 commit into from Nov 24, 2022

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Nov 23, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • removed the temp folder prefix from the related resource id field in helm and kustomize Image Referencer reports

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

achiar99
achiar99 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@achiar99 achiar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gruebel gruebel merged commit 83622ae into bridgecrewio:master Nov 24, 2022
@gruebel gruebel deleted the fix-resource-id branch November 24, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiar99 achiar99 achiar99 approved these changes

@ayajbara ayajbara ayajbara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gruebel @achiar99 @ayajbara