Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform(secrets): remove the use of enable_secret_scan_all_files for custom secrets #3954

Merged
merged 2 commits into from Dec 1, 2022

Conversation

lirshindalman
Copy link
Contributor

'remove the use of enable_secret_scan_all_files for custom secrets

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@lirshindalman lirshindalman changed the title remove the use of enable_secret_scan_all_files for custom secrets feat(platform):remove the use of enable_secret_scan_all_files for custom secrets Dec 1, 2022
@lirshindalman lirshindalman changed the title feat(platform):remove the use of enable_secret_scan_all_files for custom secrets feat(secrets):remove the use of enable_secret_scan_all_files for custom secrets Dec 1, 2022
@gruebel gruebel changed the title feat(secrets):remove the use of enable_secret_scan_all_files for custom secrets platform(sca): remove the need of enable-secret-scan-all-files flag for custom secrets Dec 1, 2022
@gruebel gruebel changed the title platform(sca): remove the need of enable-secret-scan-all-files flag for custom secrets platform(secrets): remove the need of enable-secret-scan-all-files flag for custom secrets Dec 1, 2022
@lirshindalman lirshindalman changed the title platform(secrets): remove the need of enable-secret-scan-all-files flag for custom secrets platform(secrets):remove the use of enable_secret_scan_all_files for custom secrets Dec 1, 2022
@lirshindalman lirshindalman changed the title platform(secrets):remove the use of enable_secret_scan_all_files for custom secrets platform(secrets): remove the use of enable_secret_scan_all_files for custom secrets Dec 1, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@lirshindalman lirshindalman merged commit d8d848c into main Dec 1, 2022
@lirshindalman lirshindalman deleted the fix_custom_secrets_F branch December 1, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants