Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Fix some issues in dynamic blocks flow #4002

Merged
merged 3 commits into from Dec 7, 2022
Merged

fix(terraform): Fix some issues in dynamic blocks flow #4002

merged 3 commits into from Dec 7, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Dec 7, 2022 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix some issues in the dynamic blocks flow

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

achiar99
achiar99 approved these changes Dec 7, 2022
View reviewed changes
checkov/terraform/graph_builder/variable_rendering/renderer.py
@@ -419,7 +424,7 @@ def _assign_dynamic_value_for_list(
if block_content.get(dynamic_argument) and LOOKUP in block_content.get(dynamic_argument):
block_conf[dynamic_argument] = get_lookup_value(block_content, dynamic_argument)
else:
block_conf[dynamic_argument] = block_conf[dynamic_argument]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

@ChanochShayner ChanochShayner merged commit 60c6a81 into main Dec 7, 2022
@ChanochShayner ChanochShayner deleted the dynamic-blocks-fixes branch December 7, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiar99 achiar99 achiar99 approved these changes

@YaaraVerner YaaraVerner YaaraVerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChanochShayner @achiar99 @YaaraVerner