feat(kubernetes): added deployment name to pod resource id #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo156
approved these changes
Dec 11, 2022
ChanochShayner
approved these changes
Dec 11, 2022
gruebel
reviewed
Dec 12, 2022
| @@ -147,6 +147,9 @@ def _extract_nested_resources_recursive(conf: Dict[str, Any], all_resources: Lis | |||
| if not template or not isinstance(template, dict): | |||
| all_resources.append(conf) | |||
| return | |||
| if conf.get('kind') == 'Deployment': | |||
| # means this is a Pod resource nested in a Deployment resource | |||
| template[PARENT_RESOURCE_KEY_NAME] = conf.get('metadata', {}).get('name', "") | |||
There was a problem hiding this comment.
the idea was to add the resource ID of the parent, then it is easier to query it later.
template[PARENT_RESOURCE_ID_KEY_NAME] = ...
gruebel
approved these changes
Dec 13, 2022
| @@ -147,6 +147,10 @@ def _extract_nested_resources_recursive(conf: Dict[str, Any], all_resources: Lis | |||
| if not template or not isinstance(template, dict): | |||
| all_resources.append(conf) | |||
| return | |||
| if conf.get('kind') == 'Deployment': | |||
| # means this is a Pod resource nested in a Deployment resource | |||
| template[PARENT_RESOURCE_ID_KEY_NAME] = get_resource_id(conf) | |||
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Dec 13, 2022
…wio#4040) * changed pod resource id * use const for parent key name * improve ut * fixed ut * removed empty dict * added parent resource_id
gruebel
pushed a commit
to gruebel/checkov
that referenced
this pull request
Dec 13, 2022
…wio#4040) * changed pod resource id * use const for parent key name * improve ut * fixed ut * removed empty dict * added parent resource_id
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
concatenate the Deployment resource's name to the nested Pod's resource id and adding it to the Pod's config in
_parent_resourceChecklist: