Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gha): add infra for gha graphs #4052

Merged
merged 5 commits into from Dec 12, 2022
Merged

feat(gha): add infra for gha graphs #4052

merged 5 commits into from Dec 12, 2022

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Dec 12, 2022

Description

This PR adds graph utils methods to GHA so that it will be used when constructing and deconstructing a graph.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@maxamel maxamel marked this pull request as ready for review December 12, 2022 10:36
lirshindalman
lirshindalman reviewed Dec 12, 2022
View reviewed changes
checkov/github_actions/utils.py
for file_path in file_paths:
result = parse_file(f=file_path)
if result is not None:
definitions[str(file_path)] = result[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add examples of the 'result' to better understand what is expected to be in result[0], and result[1]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added a clarification comment :)

@maxamel maxamel merged commit c95f136 into main Dec 12, 2022
@maxamel maxamel deleted the add-gha-graph-infra branch December 12, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrodkor nimrodkor nimrodkor approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxamel @nimrodkor @lirshindalman