Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): added CKV2_K8S_EXAMPLE_1 only in tests as an example for k8s graph check for pod which is publicly accessible #4060

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Dec 12, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added CKV2_K8S_EXAMPLE_1 as an example for k8s graph check for pod which is publicly accessible.
Note this is just used in tests to provide an example, and is not a real check.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156
Copy link
Contributor Author

bo156 commented Dec 12, 2022

For those who review - the request was to create this check just as an example, so I put it inside the tests folder.
However, I'm not sure this is the correct place for that, so let me know if it isn't.

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell, it looks like the right place 🙂

@bo156 bo156 merged commit 39a846c into main Dec 13, 2022
@bo156 bo156 deleted the feature/k8s-example-graph-check-pod-publicly-accessible branch December 13, 2022 08:47
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 13, 2022
…e for k8s graph check for pod which is publicly accessible (bridgecrewio#4060)

* Added a test check as an example for k8s graph check for a publicly accessible pod

* Added passing case and simplified the check
gruebel pushed a commit to gruebel/checkov that referenced this pull request Dec 13, 2022
…e for k8s graph check for pod which is publicly accessible (bridgecrewio#4060)

* Added a test check as an example for k8s graph check for a publicly accessible pod

* Added passing case and simplified the check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants