Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): fix edge-case in CKV_AZURE_37 check #4153

Merged
merged 1 commit into from Dec 26, 2022
Merged

fix(terraform): fix edge-case in CKV_AZURE_37 check #4153

merged 1 commit into from Dec 26, 2022

Conversation

YaaraVerner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

fix edge-case in CKV_AZURE_37 check

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

bo156
bo156 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@bo156 bo156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing and appreciated work.
As the head of the table in the last weekly, I hereby approve you!

@YaaraVerner YaaraVerner merged commit 6ac5be3 into main Dec 26, 2022
@YaaraVerner YaaraVerner deleted the fix_MonitorLogProfileRetentionDays_check branch December 26, 2022 15:59
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Dec 26, 2022
@YaaraVerner @actions-user
fix(terraform): fix edge-case in CKV_AZURE_37 check (bridgecrewio#4153)
88e1991 
fix check edge-case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd approved these changes

@bo156 bo156 bo156 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaaraVerner @tronxd @bo156