-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): Add resource attributes to omit arg #4193
Conversation
This reverts commit ced5447.
…r]] instead of Dict[str, List[str]]. \n 2 - replace plan runner hardcoded RESOURCE_ATTRIBUTES_TO_OMIT with the runner filter one (I updated the runner filter accordingly).\n 3 - Remove redundant print in runner filter.
…r]] instead of Dict[str, List[str]]. \n 2 - replace plan runner hardcoded RESOURCE_ATTRIBUTES_TO_OMIT with the runner filter one (I updated the runner filter accordingly).\n 3 - Remove redundant print in runner filter.
…nto add-resource-attr-to-omit-arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure, if should allow passing '*' for resource types, also the these are not all runners and some runners have both Python checks and graph checks.
3cef6fb
to
cc04bba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: arielkru <63583491+arielkru@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Adding the option to supply Checkov a config file (JSON format) that has resource to attributes.
By using this config, one can mask desired values from is scanning (for example: Secret values in the config)
*
Checklist: