Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secrets): add logs to secrets #4213

Merged
merged 3 commits into from Jan 8, 2023
Merged

fix(secrets): add logs to secrets #4213

merged 3 commits into from Jan 8, 2023

Conversation

lirshindalman
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
add debug logs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@lirshindalman lirshindalman changed the title add logs to secrets fix(secrets): add logs to secrets Jan 8, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2023
View reviewed changes
checkov/secrets/plugins/custom_regex_detector.py
@@ -41,7 +41,7 @@

def modify_secrets_policy_to_detectors(policies_list: List[dict[str, Any]]) -> List[dict[str, Any]]:
secrets_list = transforms_policies_to_detectors_list(policies_list)
logging.info(f"(modify_secrets_policy_to_detectors) secrets_list = {secrets_list}")
logging.debug(f"(modify_secrets_policy_to_detectors) secrets_list = {secrets_list}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text. This expression logs [sensitive data (secret)](3) as clear text. This expression logs [sensitive data (secret)](4) as clear text. This expression logs [sensitive data (secret)](5) as clear text. This expression logs [sensitive data (secret)](6) as clear text.
@lirshindalman lirshindalman merged commit c17a318 into main Jan 8, 2023
@lirshindalman lirshindalman deleted the filter_custom_secret_in_terminal branch January 8, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman approved these changes

@marynaKK marynaKK marynaKK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lirshindalman @Eliran-Turgeman @marynaKK