Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Fix policy str in graph checks #4286

Merged
merged 15 commits into from Jan 22, 2023
Merged

fix(terraform): Fix policy str in graph checks #4286

merged 15 commits into from Jan 22, 2023

Conversation

achiar99
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes

In policy resource type the hcl parser parse the policy as str, and we cant run the checks
The fix is to convert the policy attribute value to object

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@achiar99 achiar99 merged commit 684f1ab into main Jan 22, 2023
@achiar99 achiar99 deleted the fix-policy-str branch January 22, 2023 08:11
YaaraVerner pushed a commit that referenced this pull request Jan 22, 2023
* conflict

* Revert "conflict"

This reverts commit ced5447.

* revert

* revert

* revert

* fix policy attribute render as str

* fix

* log

* mypy

* remove

* fix test

Co-authored-by: Adam Varsano <avarsano@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants