Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): add missing header in --list output #4329

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

mj-jadhav
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Running checkov --list results in an incorrect number of headers.

Expected:

Id Type Entity Policy IaC Resource Link
0 CKV_AWS_2 resource AWS::ElasticLoadBalancingV2::Listener Ensure ALB protocol is HTTPS Cloudformation resource_link

Actual:

Id Type Entity Policy IaC
0 CKV_AWS_2 resource AWS::ElasticLoadBalancingV2::Listener Ensure ALB protocol is HTTPS Cloudformation resource_check_link

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, great catch 🏆

@gruebel gruebel merged commit 1dd8d71 into bridgecrewio:main Jan 25, 2023
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Jan 26, 2023
fix(general): add missing header in --list checks output
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Jan 26, 2023
fix(general): add missing header in --list checks output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants