feat(terraform): Added base class for cloudsplaining iam checks to be integrated between data and resource objects #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo156
force-pushed
the
feature/bce-12485-create-base-cloudsplaining
branch
from
7bbf027
to
a8e39e8
Compare
bo156
force-pushed
the
feature/bce-12485-create-base-cloudsplaining
branch
from
293248a
to
476ac4b
Compare
bo156
force-pushed
the
feature/bce-12485-create-base-cloudsplaining
branch
from
476ac4b
to
4fff87d
Compare
tronxd
approved these changes
Jan 29, 2023
bo156
force-pushed
the
feature/bce-12485-create-base-cloudsplaining
branch
from
d8b3e88
to
94431a7
Compare
achiar99
approved these changes
Jan 29, 2023
gruebel
reviewed
Jan 29, 2023
| ) | ||
|
|
||
|
|
||
| class BaseTerraformCloudsplainingDataIAMCheck(BaseDataCheck, BaseTerraformCloudsplainingIAMScanner, ABC): |
There was a problem hiding this comment.
not sure, why you subclass ABC here? there are no abstract annotations used.
There was a problem hiding this comment.
Actually we also need to implement cloudformation_analysis which is only in the check itself
| from checkov.terraform.checks.utils.base_cloudsplaining_iam_scanner import BaseTerraformCloudsplainingIAMScanner | ||
|
|
||
|
|
||
| class BaseTerraformCloudsplaininResourceIAMCheck(BaseResourceCheck, BaseTerraformCloudsplainingIAMScanner, ABC): |
|
|
||
| from checkov.common.models.enums import CheckResult | ||
|
|
||
| from cloudsplaining.scan.policy_document import PolicyDocument # noqa: TC002 |
There was a problem hiding this comment.
you can actually move it under TYPE_CHECKING, but then you also have to import annotations
andyloughran
pushed a commit
to andyloughran/checkov
that referenced
this pull request
Feb 10, 2023
… integrated between data and resource objects (bridgecrewio#4338) * Created abstraction for cloudsplaining to be used between resource and data in terraform * Added base resource check class for cloudsplaining * Removed usage of resource and data specific scanners * returned setup to normal * flake8 * fixed import * remove abc usage * fixed double class error in tests * Renamed classes and cache to use terraform to avoid similarities with cache in cloudformation * Renamed file * Returned abc usa\ge * ignore linting error as without it performence tests fail * Returned the cache name to be without terraform * Fixed parsing of policy in baseresouce check * fixed flake with import future annotations * Used correct class to initialize cache and fix the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added a base class for handling
clousplainingchecks, to allow future support of bothresourceanddatachecks without code duplication.Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: