Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Terraform checks fixes #4344

Merged
merged 4 commits into from
Jan 29, 2023
Merged

fix(terraform): Terraform checks fixes #4344

merged 4 commits into from
Jan 29, 2023

Conversation

ChanochShayner
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

Comment on lines +37 to +38
["glacier:InitiateJob"],
["glacier:GetJobOutput"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@ChanochShayner ChanochShayner merged commit 36c1a91 into main Jan 29, 2023
@ChanochShayner ChanochShayner deleted the tf-checks-fixes branch January 29, 2023 07:03
ChanochShayner added a commit that referenced this pull request Jan 29, 2023
* tf checks fixes

* check fix

* check fix
andyloughran pushed a commit to andyloughran/checkov that referenced this pull request Feb 10, 2023
* tf checks fixes

* check fix

* check fix
andyloughran pushed a commit to andyloughran/checkov that referenced this pull request Feb 10, 2023
* tf checks fixes

* check fix

* check fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants