Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secrets): support git history scan in multiline parsers #4637

Merged
merged 12 commits into from
Mar 13, 2023
Merged

feat(secrets): support git history scan in multiline parsers #4637

merged 12 commits into from
Mar 13, 2023

Conversation

lirshindalman
Copy link
Contributor

support git history scan in multiline parsers

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pazbechor pazbechor self-requested a review March 12, 2023 08:02
omryMen
omryMen reviewed Mar 12, 2023
View reviewed changes
checkov/main.py Outdated Show resolved Hide resolved
@lirshindalman @Eliran-Turgeman
Update checkov/secrets/plugins/detector_utils.py
5611907 
Co-authored-by: Eliran Turgeman <50831652+Eliran-Turgeman@users.noreply.github.com>
@lirshindalman lirshindalman merged commit c9ec872 into main Mar 13, 2023
@lirshindalman lirshindalman deleted the support_git_history_scan_in_multiline_parsers branch March 13, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omryMen omryMen omryMen left review comments

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman left review comments

@arielkru arielkru arielkru approved these changes

@pazbechor pazbechor pazbechor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lirshindalman @omryMen @Eliran-Turgeman @arielkru @pazbechor